Fix-should-panic-lint #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in stead, the message has been wrapped in `.context()`, which wraps the originating error in an anyhow error with the specified message, so that, in stead of panicking, the error gets bubbled up, logged and tracked, and then the program exits with the span traces belonging to that error. this is much cleanner and healthier than panicking, so that's the reason I'm going with this
in stead, wrap the message with `anyhow::context`, then bubble it upward
in stead, anyhow::context is being used, to wrap the error the signature of a function was changed to return a result, the test did likewise have to change to accomodate it. Luckily, that function was used only in one test
this is done because I can't meaningfully use error propagation in that context, since the unwrapping happens inside the declaration of a lazy static, but the explicit allow had to be added in order to eliminate all clippy warnings
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 14.15% 14.33% +0.17%
==========================================
Files 16 16
Lines 1533 1556 +23
==========================================
+ Hits 217 223 +6
- Misses 1316 1333 +17 ☔ View full report in Codecov by Sentry. |
mostly related to using try_into instead of into, add explicit matching on unit types in stead of _, etc this should hopefully fix most of the warnings which make our clippy test fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is especially needed because without it, everyone else's pull requests will break on the CI step, requiring ignoring by maintainers, which is harder work because now we have to filter out what we know to be clippy errors related to legacy code, and what is new lints detected on new code, which no one should do
assuming this passes tests, it should be merged right away, and existing unmerged pull requests should afterwards rebase upon main